Skip to content

(governed MCMS mode for the Stellar forwarder changesets - #23563

Merged
ilija42 merged 1 commit into
developfrom
mcms-stellar
Sep 2, 2026
Merged

(governed MCMS mode for the Stellar forwarder changesets#23563
ilija42 merged 1 commit into
developfrom
mcms-stellar

Conversation

@ilija42

@ilija42 ilija42 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Requires

Supports

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@trunk-io

trunk-io Bot commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@ilija42 ilija42 changed the title temp (governed MCMS mode for the Stellar forwarder changesets Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

CORA - Analysis Skipped

Reason: The number of code owners (4) is less than the minimum required (5) and/or the number of CODEOWNERS entries with changed files (2) is less than the minimum required (2).

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@ilija42
ilija42 force-pushed the mcms-stellar branch 2 times, most recently from b05120a to e40a558 Compare September 1, 2026 18:56
@ilija42
ilija42 changed the base branch from develop to chore/bump-go-mcms September 1, 2026 18:56
@ilija42 ilija42 mentioned this pull request Sep 1, 2026
Merged
@cl-sonarqube-production

cl-sonarqube-production Bot commented Sep 1, 2026

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
17.6% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

Base automatically changed from chore/bump-go-mcms to develop September 1, 2026 22:24
@ilija42
ilija42 marked this pull request as ready for review September 1, 2026 22:36
@ilija42
ilija42 requested review from a team as code owners September 1, 2026 22:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-01T22:40:30.644575Z ff400f8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ilija42
ilija42 requested a review from kalverra September 1, 2026 22:37
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Sep 1, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff400f84da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread deployment/cre/forwarder/stellar/mcms.go
Comment thread deployment/cre/forwarder/stellar/mcms.go
@ilija42
ilija42 added this pull request to the merge queue Sep 2, 2026
Merged via the queue into develop with commit 58ead78 Sep 2, 2026
221 checks passed
@ilija42
ilija42 deleted the mcms-stellar branch September 2, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@jmank88 jmank88 jmank88 approved these changes
@george-dorin george-dorin george-dorin approved these changes
@ajaskolski ajaskolski Awaiting requested review from ajaskolski
@MStreet3 MStreet3 Awaiting requested review from MStreet3
@bolekk bolekk Awaiting requested review from bolekk
@kalverra kalverra Awaiting requested review from kalverra
@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ilija42 @jmank88 @george-dorin